Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed /api/v1 prefix for HTTP paths #32

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Removed /api/v1 prefix for HTTP paths #32

merged 1 commit into from
Jun 10, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented May 23, 2024

What was changed

  • Remove the /api/v1 path from HTTP API. This is technically a 💥 breaking change, but the HTTP API has not been publicly/fully released from a Temporal product perspective.
  • Just noticed Add service account CRUD APIs #26 didn't have the common path prefix, so fixed that as well

Checklist

  1. Closes feat: add owner and finance admin roles CLD-3326 #39

@cretz cretz requested a review from a team May 23, 2024 19:38
@cretz cretz merged commit 05af6e5 into main Jun 10, 2024
3 checks passed
@cretz cretz deleted the alter-http-paths branch June 10, 2024 20:09
@nikki-dag nikki-dag mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anekkanti anekkanti anekkanti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cretz @anekkanti